search

johnmchambers / XRJulia

XR-style Interface to Julia (from "Extending R")
33 stars 2 forks source link

Change ASCIIString to String #5

Closed mguzmann closed 6 years ago

mguzmann commented 6 years ago

Using ASCIIString doesn't seem to work any more. I simply changed it to String in my package and it works fine.

johnmchambers commented 6 years ago

That was fixed on the github version (in February), after the incompatible change in Julia 0.5. Are you using the CRAN version? (Note that some more changes were committed today, for more changes in Julia 0.6)

mguzmann commented 6 years ago

I am using the CRAN version, yes. Will you be updating the package in CRAN too?

johnmchambers commented 6 years ago

Yes, with both sets of changes. (But when posting an issue on github, you should test against the github source to avoid confusion.)