search

johnmckerrell / OpenStreetView

An open licensed repository of street level photography, with metadata.
http://www.openstreetview.org/
32 stars 16 forks source link

OSV should provide some way easy to display full size version of the image #15

Open PetrDlouhy opened 14 years ago

PetrDlouhy commented 14 years ago

OSV should provide some way easy to display full size version of the image. It is the biggest usability issue for now, I think. It could be done by clicking on the image (maybe with some key modifier, or right clicking).

PetrDlouhy commented 14 years ago

Maybe we can get inspired by [1], where photos are clickable. [1] http://photosm.broadbox.de/

promeneur commented 14 years ago

yes this a priority to make openstreetview a honeypot

ojflewis commented 12 years ago

I have written some code to popup the medium size, with a further link to the large size.

Test server is here: http://54.247.166.63:3000/ (for a limited time).

promeneur commented 12 years ago

i tested with firefox 11.0

it works

i suggest an improvement : add a way to switch from large size to medium size

when you display the large size there is only a way to retrurn to web pageusing the back arrow of the browser but no way to retrun to the medium size

promeneur commented 12 years ago

there is a pb

display large size then return to the map then you can't zoom in the map you must zoom out then you can zoom in again

ojflewis commented 12 years ago

This seems to be a general problem which is already present on OSV. When you navigate away from a map page (e.g. to login) then hit "back", the + button no longer works. Please raise it as a separate bug - not sure if it's within my capabilities to fix. I agree that showing the large image on its own html page would be ideal but for now I think the solution works.

ojflewis commented 12 years ago

As a tweak, I'm getting the large image to open in a new tab. This avoids the problem with the back button, without solving it.

promeneur commented 12 years ago

it's a bit strange ( heterogeneous ) but it works

promeneur commented 12 years ago

when will this function be added to openstreetview.org ?

ojflewis commented 12 years ago

When John has taken a look and confirmed he is happy with it, I will update the code on Github and issue a "pull request", which should make it easy for him to merge in my changes.

johnmckerrell commented 12 years ago

Hello, actually I had missed this entire conversation, only noticed because I glanced at the homepage of github! In Safari the info box never resizes to the full size of the image, it stays really small. Good job taking this on though :-)

ojflewis commented 12 years ago

I had also posted a message to the OSM Photos mailing list but I don't know if you saw that. The test server has been running really slowly, so I'm wondering if the box didn't resize because the medium size photo hadn't finished loading. I restarted the server and tried the test site on Safari on ipad and it works fine. I don't have access to Safari on a Mac. Could you let me know if there's still problem? If there is, it will be generic to OpenLayers as I used standard code from their examples page.

johnmckerrell commented 12 years ago

I just tried again and it didn't work I'm afraid. Right now I don't have any time to look into this but if you do get to the stage of sending a pull request I should be able to manage that!

ojflewis commented 12 years ago

Strange. I will install Safari on Windows and see if I can replicate the problem.

ojflewis commented 12 years ago

OK, so it seems to work on Safari on Windows but in the process of looking into this, I figured the Openlayers library has changed a bit since you started OpenStreetView and some bugs might be coming from not using the latest version. I updated the code on the test server to link directly to the latest Openlayers. This broke the ability to open the popups on an ipad, so I also added a "touchstart" event. The popups are now working on Safari for Windows and Safari for ipad. I pushed these changes to Github in case anyone wants to look at the code. Could someone have another look on a Mac? Please note the test server can be very slow - please leave the window with the popup open for a while - it will only resize when the medium size picture has finished loading.

johnmckerrell commented 12 years ago

Still doesn't seem to be working on Safari here but at this point I'm willing to leave it, I'll try to have a look when doing the merge.

ojflewis commented 12 years ago

OK thanks. I will issue the pull request. Once it's running on your server I will try to debug it again. Note that my code creates a link to openlayers.org. Not sure if that's the right way to do it or whether a new local copy of the current openlayers.js is required.