search

johnmckerrell / OpenStreetView

An open licensed repository of street level photography, with metadata.
http://www.openstreetview.org/
32 stars 16 forks source link

[patch] Remove direct dependency to ajax.googleapis.com (privacy issue) #30

Open tetraf opened 11 years ago

tetraf commented 11 years ago

Patch to use with git apply: https://gist.github.com/tetraf/5611870

alexandre-mbm commented 10 years ago

Is @johnmckerrell no longer maintaining this repository? If I made a pull request with the patch above, would it be accepted?

johnmckerrell commented 10 years ago

I'm still here but don't get time to do anything with OSV, if you submit a pull request I should be able to apply it.

alexandre-mbm commented 10 years ago

Thank you. I will do some requests in the coming days.

Can you tell which is the license you want to use?

alexandre-mbm commented 10 years ago

I have a local branch for pull request. I used the tips about git apply. I made the fixes about which I commented at the Gist tetraf/remove_googleapis.patch. I ran a quick test and it showed no problems.

Accepting the pull request will entail accepting the jQuery's code dual licensed under the MIT (MIT-LICENSE.txt) and GPL (GPL-LICENSE.txt) licenses. Do I send the pull request?

johnmckerrell commented 10 years ago

Yes please do, I think it's fine to do that as a library.

On 13 Mar 2014, at 11:44, Alexandre Magno notifications@github.com wrote:

I have a local branch for pull request. I used the tips about git apply. I made the fixes about which I commented at the Gist tetraf/remove_googleapis.patch. I ran a quick test and it showed no problems.

Accepting the pull request will entail accepting the jQuery's code dual licensed under the MIT (MIT-LICENSE.txt) and GPL (GPL-LICENSE.txt) licenses. Do I send the pull request?

— Reply to this email directly or view it on GitHub.

alexandre-mbm commented 10 years ago

But we would be redistributing it. No problem?

johnmckerrell commented 10 years ago

I'm going to say "Yes", no problem. I believe it's ok as a library.

On 13 Mar 2014, at 12:10, Alexandre Magno notifications@github.com wrote:

But we are redistributing it. No problem?

— Reply to this email directly or view it on GitHub.