search

johnmehr / gitup

A minimalist, dependency-free FreeBSD program to clone/pull Git repositories.
BSD 2-Clause "Simplified" License
50 stars 9 forks source link

Drop port auto-config script #102

Open nunotexbsd opened 9 months ago

nunotexbsd commented 9 months ago

I'm dealing with https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274955 and can't find a way to solve it. pkg-post-install changes gitup.conf.sample after it gets installed and because of that we get a pkg mismatched checksum.

My opinion continues the same as at the begining of the port creation, do not do this changes with ports framework, do not do this pkg-post-install script.

Looking at other ports with more or less complexity, they tell user to see examples, pkgname.conf.sample file and it's manual pkgname.conf(8). Also, gitup.conf{.sample} could have more details about FreeBSD branches to follow.

Any help is welcome. Thanks

grahamperrin commented 9 months ago

+1 to dropping automation or scripting that is not fairly easy to fix. That's not defeatist, just realistic.

grahamperrin commented 9 months ago

Re: the required configuration file, a change to the package message (represented at FreshPorts) will be good, I think.

This is off-topic from the proposed drop, so I'll hide this comment. @nunotexbsd @johnmehr if either of you would like suggested changes, let me know, I can make a PR in this repo.

johnmehr commented 9 months ago

I'm unfamiliar with FreeBSD's ports architecture, but that's no excuse for me not to learn. :)

I'm ok with dropping the automation and I can manually make changes to gitup.conf whenever new OS releases happen. Should I go ahead and update releng to 14.0 in gitup.conf?

johnmehr commented 9 months ago

Also, do you know how we can replicate the error Denis is encountering?

Do you know if the same problems happen with net/svnup? During install, svnup.conf is also updated with the current OS version. Maybe there is a potential solution there.

nunotexbsd commented 8 months ago

Also, do you know how we can replicate the error Denis is encountering?

Do you know if the same problems happen with net/svnup? During install, svnup.conf is also updated with the current OS version. Maybe there is a potential solution there.

net/svnup do changes at build time what gives erroneous info, e.g., pkg builder for 13.2-RELEASE is 13.1-RELEASE, etc

The idea of doing such changes/updates comes with a script that is executed at install time and this way giving user exact values.

If you take a look at PR (updated with more tests) we are getting problems related to mismatch/leftover files because we are messing with @sample macro or with it functionality.