johnmehr / gitup

A minimalist, dependency-free FreeBSD program to clone/pull Git repositories.
BSD 2-Clause "Simplified" License
50 stars 9 forks source link

defaults in gitup.conf and gitup.conf.sample #77

Closed grahamperrin closed 2 years ago

grahamperrin commented 2 years ago

With a fresh installation:

image


Side note: https://forums.freebsd.org/posts/559707

By the way, a freshly upgraded stable/13 system now labels itself 13.1-STABLE.

johnmehr commented 2 years ago

I just sent an email to the port maintainer asking if the code in net/svnup that automatically updates the config file's default OS version to match the computer's OS version can be copied over to net/gitup. Thanks!

grahamperrin commented 2 years ago

Thanks.

https://github.com/johnmehr/gitup/commit/25198561b67b14b3b6b16b4cc82e0d0635a882d2#diff-39bd767a59a3138594332fbe99b51c0e531831ee92817e389b3435e1dd1474f9R51

https://github.com/johnmehr/gitup/commit/25198561b67b14b3b6b16b4cc82e0d0635a882d2#diff-39bd767a59a3138594332fbe99b51c0e531831ee92817e389b3435e1dd1474f9R36

– the configuration file(s) can be updated to releng/13.1, soon.

https://www.freebsd.org/releases/13.1R/schedule/

nunotexbsd commented 2 years ago

net/svnup uses a reinplace command to automate stable and releng in config file but it fails when user is using CURRENT because it gives stable/14 and releng/14.0. I really like this automation but it must be fixed to CURRENT to avoid results like:

[release]
branch=base/releng/14.0
target=/usr/src

[stable]
branch=base/stable/14
target=/usr/src

IMO gitup config should always be an example and then user should track whatever he wants, stable or release or current.

My question is, what results should gitup.conf for CURRENT users?

[release]
branch=NULL
target=/usr/src

[stable]
branch=NULL
target=/usr/src
grahamperrin commented 2 years ago

Automation will be nice, but for now (without too much delay), can the port be updated in a simple way?

For gitup.conf to have, at least, 13.1 in lieu of 11.4 for release.

Thanks

johnmehr commented 2 years ago

I updated it to 12.3 but it looks like I neglected to commit it. :(

Until the automation is implemented, I'd like to use the oldest supported version, assuming it has the largest number of deployed instances. Do you know of any stats out there that show the percentage breakdown of the currently supported versions deployed in the world?

@nunotexbsd, do you know if there has been any progress in reusing the code that Jason implemented for svnup? Thanks!

nunotexbsd commented 2 years ago

Hello,

The problem is that svnup automation doesn't work correctly on CURRENT svnup.conf: `[release] branch=base/releng/14.0 [1] target=/usr/src

[ports] branch=ports/head target=/usr/ports

[stable] branch=base/stable/14 [2] target=/usr/src`

[1][2] neither releng 14.0 or stable 14 exists

I've talked with Jason about doing some adjustments but still nothing

johnmehr commented 2 years ago

I'm ok with this being a known issue for these two cases -- everyone with a commit bit would know that RELENG and STABLE do not exist and non-committers who choose to track CURRENT have been warned in the FreeBSD Handbook that this is not without risks.

nunotexbsd commented 2 years ago

Ok, I will update port tomorrow morning with reinplace cmd: gitup.conf@0.97: release 11.4 and stable 12. Next version, maybe I need to adjust reinplace cmd if config file OS version changes.

Cheers

nunotexbsd commented 2 years ago

Hello,

Commit done.

I've done interactive poudriere tests with 12.3 and 13.1 with success, automation works accordingly with those versions.

I'm thinking in a 'if ${OSREL}' condition == 14.0 to give a solution for CURRENT, well it's easy to implement but I don't know what to put into 'releng' and 'stable' :)

Cheers

johnmehr commented 2 years ago

This should be implemented now. Thank you!