johnmichel / Library-Detector-for-Chrome

🔍 Extension that detects which JavaScript libraries are running on a page
https://chrome.google.com/webstore/detail/cgaocdmhkmfnkdkbnckgmpopcbpaaejo
MIT License
662 stars 111 forks source link

Determine if numeric version field is OK #160

Open paulirish opened 4 years ago

paulirish commented 4 years ago

In Lighthouse we had some code the assumed the .version property on a discovered library would be a string. But in the Magento 2 case, it's a number literal.

We're now casting to a string, so we'll be fine, but I wanted to raise it here in case other consumers may make similar assumptions.