search

johnmyleswhite / Vega.jl

A Julia package for generating visualizations in Vega
Other
84 stars 22 forks source link

Use dirname(@__FILE__) instead of Pkg.dir #144

Closed tkelman closed 8 years ago

tkelman commented 8 years ago

Add testing against 0.5 to Travis this runs the most recent release candidate now, release once final tags are done

add Compat to REQUIRE and Distributions to test/REQUIRE instead of assuming they will be present as indirect dependencies

And just a note so you're aware, the way in which you're doing conditional dependencies here for optional Blink and Escher integration is deeply incompatible with precompilation. If the set of packages present at precompile time does not match the set of dependencies present at runtime, you will get either less functionality or errors. Until extern gets implemented, the only reliable way to do this would be to separate the conditional dependencies into a separate package that can depend on both.

randyzwitch commented 8 years ago

Thanks @tkelman. If factoring out the package into another package is the best way to handle this, then I might as well add them to REQUIRE directly for now.