johnno1962 / GitDiff

Highlights deltas against git repo in Xcode
MIT License
891 stars 54 forks source link

Crash when open Xcode source control editor #2

Closed vinhnx closed 10 years ago

vinhnx commented 10 years ago

First, thanks for this awesome plugin.

I have encountered a crash in Xcode 5.1.1, when using Xcode source control editor.

Here is the excerpt from crash log.

...
Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000

Application Specific Information:
ProductBuildVersion: 5B1008
UNCAUGHT EXCEPTION (NSInvalidArgumentException): -[DVTComparisonScrollCoordinator delegate]: unrecognized selector sent to instance 0x7fb58405a9b0
UserInfo: (null)
Hints: None
Backtrace:
  0  0x00007fff90297bd4 __exceptionPreprocess (in CoreFoundation)
  1  0x0000000103160b10 DVTFailureHintExceptionPreprocessor (in DVTFoundation)
  2  0x00007fff845c670e objc_exception_throw (in libobjc.A.dylib)
  3  0x00007fff9029ab1d -[NSObject(NSObject) doesNotRecognizeSelector:] (in CoreFoundation)
  4  0x00007fff901e2514 ___forwarding___ (in CoreFoundation)
  5  0x00007fff901e2088 _CF_forwarding_prep_0 (in CoreFoundation)
  6  0x000000010e7f3905 -[DVTTextSidebarView(GitDiff) gitDiffs] at /Users/Vinh/Library/Application Support/Alcatraz/Plug-ins/GitDiff/Classes/GitDiff.mm:160 (in GitDiff)
  7  0x000000010e7f3ca3 -[DVTTextSidebarView(GitDiff) git_drawLineNumbersInSidebarRect:foldedIndexes:count:linesToInvert:linesToReplace:getParaRectBlock:] at /Users/Vinh/Library/Application Support/Alcatraz/Plug-ins/GitDiff/Classes/GitDiff.mm:173 (in GitDiff)
...
johnno1962 commented 10 years ago

Hi, thanks for this bug report. I’ve committed a change which resolves this problem. Cheers