search

johnno1962 / GitDiff

Highlights deltas against git repo in Xcode
MIT License
891 stars 54 forks source link

No display when line numbers disabled #21

Closed gknops closed 9 years ago

gknops commented 9 years ago

Great plugin, thank you!

I usually prefer the line numbers disabled: Xcode/preferences/Text Editing/Line numbers

However when doing that the GitDiff display also disappears, even though there would be plenty of gutter space. Any chance that could get fixed?

Thanks again!

johnno1962 commented 9 years ago

Hi,

Not sure I can help you here as the GitDiff highlighting is “swizzled” onto the method that draws the line numbers so if you turn them off the highlighting will not come out. I’ll have another look.

John

gknops commented 9 years ago

Ah, I suspected as much... I can live with the line numbers (particularly since there does not seem to be a cursor row/column position display elsewhere), so don't try to hard. I guess the plugins should be kept as simple as possible to increase their chance of working with the next version of Xcode.

Gerd

On Nov 22, 2014, at 8:29 AM, John Holdsworth notifications@github.com wrote:

Hi,

Not sure I can help you here as the GitDiff highlighting is “swizzled” onto the method that draws the line numbers so if you turn them off the highlighting will not come out. I’ll have another look.

John

— Reply to this email directly or view it on GitHub.