search

johnno1962 / GitDiff

Highlights deltas against git repo in Xcode
MIT License
891 stars 54 forks source link

Crashing Xcode 6.2 #35

Closed julian-weinert closed 9 years ago

julian-weinert commented 9 years ago

I'm getting a crash for Xcode Version 6.2 (6C131e). Here is my Xcode crash log:

Process:               Xcode [11300]
Path:                  /Applications/Xcode.app/Contents/MacOS/Xcode
Identifier:            com.apple.dt.Xcode
Version:               6.2 (6776)
Build Info:            IDEFrameworks-6776000000000000~11
App Item ID:           497799835
App External ID:       811890240
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           Xcode [11300]
User ID:               501

Date/Time:             2015-04-09 14:05:31.121 +0200
OS Version:            Mac OS X 10.10.2 (14C1514)
Report Version:        11
Anonymous UUID:        3B5A6A6E-C696-7A61-058D-9A909ED39E57

Time Awake Since Boot: 6000 seconds

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000

Application Specific Information:
ProductBuildVersion: 6C131e
UNCAUGHT EXCEPTION (NSInvalidArgumentException): NSConcreteAttributedString initWithString:: nil value
UserInfo: (null)
Hints: None
Backtrace:
  0  0x00007fff9556f654 __exceptionPreprocess (in CoreFoundation)
  1  0x0000000106c1a764 DVTFailureHintExceptionPreprocessor (in DVTFoundation)
  2  0x00007fff89da676e objc_exception_throw (in libobjc.A.dylib)
  3  0x00007fff9556f51d +[NSException raise:format:] (in CoreFoundation)
  4  0x00007fff90bc4f34 -[NSConcreteAttributedString initWithString:] (in Foundation)
  5  0x00000001167f3aee -[NSRulerView(GitDiff) gitdiff_annotationAtSidebarPoint:] (in GitDiff)
  6  0x00000001070a6cf5 -[DVTTextSidebarView _updateCurrentAnnotationRolloverStatusWithEvent:] (in DVTKit)
  7  0x00000001070a793b -[DVTTextSidebarView mouseMoved:] (in DVTKit)
  8  0x00007fff8b6f4c5a -[NSTrackingArea mouseMoved:] (in AppKit)
  9  0x00007fff8bc4fd1d -[NSWindow _reallySendEvent:] (in AppKit)
 10  0x00007fff8b6d916e -[NSWindow sendEvent:] (in AppKit)
 11  0x0000000107e87d5b -[IDEWorkspaceWindow sendEvent:] (in IDEKit)
 12  0x00007fff8b68a82c -[NSApplication sendEvent:] (in AppKit)
 13  0x0000000107c2fdd4 -[IDEApplication sendEvent:] (in IDEKit)
 14  0x00007fff8b517608 -[NSApplication run] (in AppKit)
 15  0x00007fff8b502a14 NSApplicationMain (in AppKit)
 16  0x00007fff95b0a5c9 start (in libdyld.dylib)
 17  0x0000000000000001

abort() called

Application Specific Signatures:
NSInvalidArgumentException

Application Specific Backtrace 1:
0   CoreFoundation                      0x00007fff9556f66c __exceptionPreprocess + 172
1   DVTFoundation                       0x0000000106c1a764 DVTFailureHintExceptionPreprocessor + 194
2   libobjc.A.dylib                     0x00007fff89da676e objc_exception_throw + 43
3   CoreFoundation                      0x00007fff9556f51d +[NSException raise:format:] + 205
4   Foundation                          0x00007fff90bc4f34 -[NSConcreteAttributedString initWithString:] + 132
5   GitDiff                             0x00000001167f3aee -[NSRulerView(GitDiff) gitdiff_annotationAtSidebarPoint:] + 4126
6   DVTKit                              0x00000001070a6cf5 -[DVTTextSidebarView _updateCurrentAnnotationRolloverStatusWithEvent:] + 71
7   DVTKit                              0x00000001070a793b -[DVTTextSidebarView mouseMoved:] + 897
8   AppKit                              0x00007fff8b6f4c5a -[NSTrackingArea mouseMoved:] + 145
9   AppKit                              0x00007fff8bc4fd1d -[NSWindow _reallySendEvent:] + 1206
10  AppKit                              0x00007fff8b6d916e -[NSWindow sendEvent:] + 446
11  IDEKit                              0x0000000107e87d5b -[IDEWorkspaceWindow sendEvent:] + 159
12  AppKit                              0x00007fff8b68a82c -[NSApplication sendEvent:] + 1074
13  IDEKit                              0x0000000107c2fdd4 -[IDEApplication sendEvent:] + 924
14  AppKit                              0x00007fff8b517608 -[NSApplication run] + 711
15  AppKit                              0x00007fff8b502a14 NSApplicationMain + 1832
16  libdyld.dylib                       0x00007fff95b0a5c9 start + 1
17  ???                                 0x0000000000000001 0x0 + 1

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib          0x00007fff92db6286 __pthread_kill + 10
1   libsystem_c.dylib               0x00007fff884ffb53 abort + 129
2   com.apple.dt.IDEKit             0x0000000107e63d86 +[IDEAssertionHandler _handleAssertionWithLogString:assertionSignature:assertionReason:extraBacktrace:] + 1510
3   com.apple.dt.IDEKit             0x0000000107e65008 -[IDEAssertionHandler handleUncaughtException:] + 1077
4   com.apple.dt.IDEKit             0x0000000107e650d7 IDEHandleUncaughtException + 94
5   com.apple.AppKit                0x00007fff8b5176bc -[NSApplication run] + 891
6   com.apple.AppKit                0x00007fff8b502a14 NSApplicationMain + 1832
7   libdyld.dylib                   0x00007fff95b0a5c9 start + 1

       0x1167eb000 -        0x116817fff +com.johnholdsworth.GitDiff (3.6 - 3.6) <2CDC90B7-894D-3ABE-8204-8FEF78DAEA6A> /Users/USER/Library/Application Support/Developer/*/GitDiff

Model: MacBookPro11,2, BootROM MBP112.0138.B14, 4 processors, Intel Core i7, 2 GHz, 16 GB, SMC 2.18f15
Graphics: Intel Iris Pro, Intel Iris Pro, Built-In
Memory Module: BANK 0/DIMM0, 8 GB, DDR3, 1600 MHz, 0x80AD, 0x484D54343147533641465238412D50422020
Memory Module: BANK 1/DIMM0, 8 GB, DDR3, 1600 MHz, 0x80AD, 0x484D54343147533641465238412D50422020
AirPort: spairport_wireless_card_type_airport_extreme (0x14E4, 0x134), Broadcom BCM43xx 1.0 (7.15.159.13.12)
Bluetooth: Version 4.3.2f6 15235, 3 services, 27 devices, 1 incoming serial ports
Network Service: Thunderbolt Bridge, Ethernet, bridge0
Network Service: Thunderbolt Ethernet, Ethernet, en4
PCI Card: Apple 57762-A0, Ethernet Controller, Thunderbolt@195,0,0
Serial ATA Device: APPLE SSD SM0256F, 251 GB
USB Device: Internal Memory Card Reader
USB Device: BRCM20702 Hub
USB Device: Bluetooth USB Host Controller
USB Device: Apple Internal Keyboard / Trackpad
USB Device: Keyboard Hub
USB Device: Apple Keyboard
Thunderbolt Bus: MacBook Pro, Apple Inc., 17.1
Thunderbolt Device: Thunderbolt to Gigabit Ethernet Adapter, Apple Inc., 1, 5.5
johnno1962 commented 9 years ago

Hi, that doesn’t give me much to go on alas. There are only a couple of places with a -[NSMutableAttributedString initWithString:] in that method can you add in a ?:@“” to see if you can find which one is tripping up in this case?

johnno1962 commented 9 years ago

I’ve put a couple of minor changes in which might fix this. https://github.com/johnno1962/GitDiff/commit/881c2252f724a7185a39fdfce962f53159e85f49. Can you rebuild the plugin restart Xcode and retry?

julian-weinert commented 9 years ago

Yep, confirmed, fixed now! Thanks – stay awesome :)

johnno1962 commented 9 years ago

Cool. Thanks for the bug report