search

johnno1962 / GitDiff

Highlights deltas against git repo in Xcode
MIT License
891 stars 54 forks source link

Not working with CocoaPods 1.0? #58

Closed francybiga closed 8 years ago

francybiga commented 8 years ago

GitDiff is not working for me on xcode 7.3.1

I installed it from Github source and the plugin is correctly loading (I see the menu under "Edit"). Line numbers are enabled.

Any hint?

johnno1962 commented 8 years ago

Try git diff from te command line.. are your changes staged?

francybiga commented 8 years ago

git diff from command line works as expected. My changes are not staged (but even if I stage it I don't see the expected colors).

johnno1962 commented 8 years ago

Sorry, i’ve run out of ideas on this one. Changes must be unstaged for you to see them.

francybiga commented 8 years ago

The plugin started working again!

I'm not sure about the reason but it could be related to this issue in Cocoapods: https://github.com/CocoaPods/CocoaPods/pull/5382

In fact I had version 1.0 of Cocoapods (with emojii in Build Phases section of pbxproj) and, after updating to cocoapods 1.0.1 (with the emoji removal) Gitdiff started working.

Is my guess correct?

johnno1962 commented 8 years ago

Good Grief! Well spotted.

francybiga commented 8 years ago

Maybe it could be useful for others to change this issue's title to mention Cocoapods? I am not 100% sure of the cause, but I think it's still more correct than my previous guess (xcode 7.3.1)