johnno1962 / injectionforxcode

Runtime Code Injection for Objective-C & Swift
MIT License
6.55k stars 565 forks source link

AppCode installation issues #135

Closed lyahdav closed 8 years ago

lyahdav commented 8 years ago

This is an awesome plugin! I got it working very easily in Xcode, but I primarily use AppCode. I followed the instructions here, but I had a few issues (AppCode version 2016.1):

  1. I wasn't able to install the plugin by copying it to the directory specified. Instead I had to download the .jar to my Downloads folder, go into AppCode preferences, choose "Install plugin from disk", and restart the IDE.
  2. After the plugin was installed, it wasn't clear how to inject source. I assumed the same keyboard shortcut as the Xcode plugin, and that worked, but it would be nice to explain that in the instructions (and that it adds other menu items to the Run menu).
  3. The "Patch project for Injection" menu item changed a pbxproj file that was for our linter, completely not needed to get this to work. The linter project happens to be version controlled as a subfolder within the main project folder, which is how I guess it found this other project.
  4. It's nice that the Xcode version doesn't require any modifications to the project. Is this not possible with AppCode? As a workaround I added main.m to my .git/info/exclude file, but this very much seems like a hack.
johnno1962 commented 8 years ago

Hi, do you want to open a PR on the README? That would be a big help 👍

lyahdav commented 8 years ago

I created PR https://github.com/lyahdav/injectionforxcode/pull/1 for this. Any thoughts on items 3 or 4 from my list above?

johnno1962 commented 8 years ago

Can you open a pull request on your change against this repo please then I can merge it? Can’t fix 3 or 4 I’m afraid as the patch to the project is required for injection to work and AppCode only works with “patched” injection.

lyahdav commented 8 years ago

Done in https://github.com/johnno1962/injectionforxcode/pull/144.

johnno1962 commented 8 years ago

Cheers