Bug-Fix: Unhide doesn't report any warnings when build configuration is not Debug.

johnno1962 / injectionforxcode

Runtime Code Injection for Objective-C & Swift

MIT License

6.55k stars 565 forks source link

Bug-Fix: Unhide doesn't report any warnings when build configuration is not Debug. #74

Closed haskellswift closed 8 years ago

haskellswift commented 8 years ago

I found this issue when a Xcode project's default build configuration was set to Release by someone. As a result, I got a crash after code injection because unhide.sh didn't work. The bug-fix will prompt user that he should use Debug build configuration if he wants to do code injection properly.

johnno1962 commented 8 years ago

Hi, Thanks for this. Won’t it print this warning when ever the user does a release build to actually release? Would that be desirable?

haskellswift commented 8 years ago

Hi, If build configuration is not Debug, unhide.sh won't work and developers can't tell why injection doesn't work unless they dig into unhide.sh. I believe that developers use Debug more than Release. BTW, your project saves me a lot time to debug since I used it. Many thanks!

johnno1962 commented 8 years ago

Sorry but I’d rather not have a messaage that distracts people when they ar doing their final builds. It’s true that injection doesn’t work outside a debug build but people should know that if they are using it.

haskellswift commented 8 years ago

Never mind, I just don't expect people should know what I think they should know.