search

johnnovak / illwill

A curses inspired simple cross-platform console library for Nim
Do What The F*ck You Want To Public License
398 stars 27 forks source link

Make `getKey` work from threads #29

Closed ZoomRmc closed 2 years ago

ZoomRmc commented 2 years ago

In the spirit of low-effort solutions a-la #19. Makes one variable thread-local and converts one table to a const, thus allowing using getKey() from a thread.

I also ask you kindly to make a tagged release, if it's possible, so the patched version could be denoted in nimble dependency requirements of reliant packages/programs.

ZoomRmc commented 2 years ago

@johnnovak sorry for the ping. Could you please at least say if it's a no-go if it is? Any reaction would be nice.

johnnovak commented 2 years ago

Sorry, I'm a bit lazy when it comes to checking my repos these days 😊

I don't have problems with merging this into the main branch and tagging it as a proper release, as I don't see much harm in the solution. I'll merge & release it probably tomorrow.

johnnovak commented 2 years ago

@ZoomRmc Merged & created new release. Have fun :)