johnny / jquery-sortable

A flexible, opinionated sorting plugin for jQuery
http://johnny.github.io/jquery-sortable/
Other
1.52k stars 441 forks source link

Incorrect jquery dependency version specification. #262

Open ericwooley opened 5 years ago

ericwooley commented 5 years ago

https://docs.npmjs.com/misc/semver#ranges and https://yarnpkg.com/lang/en/docs/dependency-versions/#toc-unions specify the version should use a> or >= syntax not a ^.

Currently jquery-sortable uses https://github.com/johnny/jquery-sortable/blob/4d31eeaf0136307c4d70e9e2252bee001384cf72/package.json#L29

The way it is setup now, causes yarn to install jquery 2.x when jquery 3 is a top level dependency