search

johnnyb / Shifty

Simple and flexible shift register manager for Arduino
MIT License
47 stars 11 forks source link

Incorrect case of setbitMode (should be setBitMode) #5

Open Solice55 opened 7 years ago

Solice55 commented 7 years ago

A month or so ago, I submitted a pull request that fixes this: https://github.com/johnnyb/Shifty/pull/3

chopperaddict commented 7 years ago

Confirmed - this is such a simple problem to fix, just spell it correctly or create a duplicate Fn() declaration using the lower case version name as well in the "h" file,

Please update this soon.. h file shows ;- class Shifty { public: Shifty(); void setBitCount(int bitCount); void setPins(int dataPin, int clockPin, int latchPin, int readPin); void setPins(int dataPin, int clockPin, int latchPin); void setbitMode(int bitnum, bool mode);

cpp shows 👎 void Shifty::setBitMode(int bitnum, bool mode) { int bytenum = bitnum / 8; int offset = bitnum % 8; byte b = this->dataModes[bytenum]; bitSet(b, offset); this->dataModes[bytenum] = b; }

johnnyb commented 7 years ago

Sorry for the delay - it is now added in.