johnnybuggy / HOLO

HOLO - The Music Amalgamation System
Other
16 stars 7 forks source link

AppDomain shadow copy implementation refactoring #6

Closed vsoldatkin closed 11 years ago

vsoldatkin commented 11 years ago

I'm concerned about the current AppDomain shadow copy implementation. I think it is not good enough for production. I mean goto and such. It also needs to be enclosed in a preprocessor directives to allow building a "shadow copy free" debug version, because it seems to affect a VS profiler somehow, so the profiler is unable to launch the application.

I could perform a slight refactoring of that shadow copy logic.

PavelTorgashov commented 11 years ago

Personally I do not use profiler. Therefore I do not knew about problems with it.

I could perform a slight refactoring of that shadow copy logic.

That would be good.

In addition, the shadow copy was made for future features, now it is not extremely required.

vsoldatkin commented 11 years ago

I see, that may be a good idea to implement an "auto update" like feature in the future. Then the shadow copy will be particularly useful.