search

johnnyruz / OctoPrint-OctoVox

GNU General Public License v3.0
31 stars 7 forks source link

German translations. #15

Closed alx-k closed 5 years ago

alx-k commented 5 years ago

Added German translations. Im unsure if my translations for PrinterState and RequestValidationFailed are good because with the first I don't know what the variables will be replaced with and with the second one I don't know what triggers it.

alx-k commented 5 years ago

Sorry for doing two pull requests, I'm not on my usual computer and just used the web editor.

johnnyruz commented 5 years ago

Looks great! Before I merge I just want to answer your question in case there are any translation adjustments:

PrinterState: {0} will be replaced with the printer name you defined when you registered the printer {1} will be replaced with the status, right now this is just "Idle", "Printing", "Offline" etc. I probably need to add translation parameters for these as well!!

LastJobResultSuccess: {0} - this is the job name (i.e. the name of the GCODE file) {1} - this will be the Hours/Minutes/Seconds for the job duration

LastJobResultFailure: {0} - this is the job name (i.e. the name of the GCODE file) {1} - this will be the failure status which will be something like "Cancelled By User". Again, I probably need to include translations but hopefully it can go live missing this.

If this pattern still works with your translations I'll merge. Thanks again!

alx-k commented 5 years ago

Ah that's what I guessed, my translations will work with that.