search

johnnyshankman / hihat

A free & minimalist offline music player for OSX audiophiles :: Based on iTunes circa 2002
MIT License
10 stars 0 forks source link

Simplify Main Component #39

Closed johnnyshankman closed 2 weeks ago

johnnyshankman commented 3 weeks ago

This PR

Reduces complexity in Main.

Fixes #38

johnnyshankman commented 3 weeks ago

Does not pass QA. Scrolling to the currently playing song causes the UX to snap back to some other spot (i'm sure there's a pattern to what it snaps to but I'm not aware of what it is yet) when clicking on the album art, song name, or artist name.

In the dev app i tested that hiding and deleting worked so hm... interesting edge.

johnnyshankman commented 3 weeks ago

Passes QA now, optimizations meant that i need to swap between -1 and the override scrollToIndex slower because the useEffect happens more quickly now.