search

johnnyshields / naturalsort

NaturalSort is a simple library which implements a natural, human-friendly alphanumeric sort in Ruby.
MIT License
8 stars 4 forks source link

Fixes issue where empty string would break sorting #5

Closed Bertg closed 2 weeks ago

Bertg commented 8 years ago

The compare loop would exit prematurely when one of the strings would be of length 0.

This commit ensures that the default return values are the actual string when this condition happens.

johnnyshields commented 8 years ago

Thanks for PR. Looks like CI had a random failure. Can you get it to run again then I'll merge?

Bertg commented 8 years ago

Hey, the only way for me to do this would be to close and re-open the PR. I'd rather not. Or push an empty commit. I'd also rather not :p

You should be able to re-trigger the build according to this StackOverflow post: http://stackoverflow.com/questions/17606874/trigger-a-travis-ci-rebuild-without-pushing-a-commit

johnnyshields commented 8 years ago

OK I didn't know about the refresh button. Just pressed it. Travis CI keeps changing their UI.

Bertg commented 8 years ago

Hi, the test failures don't seem to be random. It seems the issue happens when bundler is trying to install rake for older versions of ruby. Maybe you should consider including a locked Gemfile?

I would start this by checking if the current "master" still builds correctly on Travis.