search

johnnythesnake12 / pe

0 stars 0 forks source link

duplicate emails #13

Open johnnythesnake12 opened 10 months ago

johnnythesnake12 commented 10 months ago

image.png

2 people should not have duplicate emails especially in the same company

nus-pe-bot commented 10 months ago

Team's Response

Refers to the same issue of duplicate emails

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicate email can be added

As seen below, I can add two people with the same email. As a HR application that manages contacts, I think this violates the spirit of your app because at no time would there be two people with the same email address in a team - or ever. This can cause erroneous inputs and emails to be added to the application.

image.png

[original: nus-cs2103-AY2324S1/pe-interim#4112] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

There may be cases in which multiple contacts can share the same work email addresses

  • For instance, communication between HR and interns may be handled through the interns' supervisors. This is because in some cases, intern turnover rate is high, and therefore creating company issued emails for interns may not be worth the necessary paperwork and hassle involved. Furthermore, due to possible restrictive nature of the work handled, companies might forbid such interns from using their personal, or self created email addresses that they would have access to after their internship attachment. Therefore, supervisors would opt to use their own email addresses in place for the intern's contact information instead, and would instead relay all necessary important information down to the interns. Thus, the email address provided will be that of their supervisor. This is a practice that is done in several companies, such as Cognizant.

As such, we have chosen to not enforce uniqueness on email addresses in the employee list.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Developers can argue that 2 people can have the same office extension and name, but from real world examples, there are definitely no 2 employees that would share the same email even if they are temporary staff or interns. Hence highlighting the need to flag out to the Hr manager when there are duplicate emails.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]