johnnythesnake12 / pe

0 stars 0 forks source link

Sequence diagram for FindLeaveByPeriod command is missing and not rendered #19

Open johnnythesnake12 opened 11 months ago

johnnythesnake12 commented 11 months ago

image.png

nus-se-bot commented 11 months ago

Team's Response

It's exactly the same issue.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Broken sequence diagram link

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


The DG contains a broken diagram link:

image.png


[original: nus-cs2103-AY2324S1/pe-interim#4844] [original labels: type.DocumentationBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Accepted. Good catch.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** This was an easily avoidable mistake if developers had checked their Sequence diagram after converting it to a PDF. Without the sequence diagram, it is essentially a missing diagram, which definitely is not a very low severity issue. Should at least be a Low severity or a Medium severity