johnnythesnake12 / pe

0 stars 0 forks source link

Why are names with only numbers accepted #5

Open johnnythesnake12 opened 10 months ago

johnnythesnake12 commented 10 months ago

image.png

If alphanumeric means either letters or numbers are accepted, i believe that by that logic, a name with just numbers should be accepted, moreover, a name with just alphabets are accepted.

nus-pe-bot commented 10 months ago

Team's Response

Allowing numbers in the name field was meant to differentiate between people with the same names e.g. appending an employee number at the back of the name. However, we still expect HR managers to key in the person's actual name at the start of the name field, which begins with an alphabetical character by convention.

Screenshot 2023-11-20 at 10.55.02 AM.png The UG segment screenshotted above provides an example of the use case mentioned earlier.

However, we recognise the vagueness of the error message in not specifying the need for the first character to be an alphabetical character and thus would include this provision in the error message/UG for improved clarity.

Additionally, we are downgrading the severity of the bug to low as we do not expect anyone's name to begin with a digit, nor for a sizeable proportion of HR managers to run into this particular error.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** This is a feature flaw as the unclear error message appeared in the CLI rather than the DG.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Error message is not clear enough as to what the error was, i.e. not specifying that names can take in numbers, but that the first letter has to be an alphabet. Users have no way of figuring out what the issue is if they repeatedly typed a name with a number at the start. For example if there was a George from 1st IT team and another George from 2nd IT team. HR manager might try to input "1st IT Team George" and "2nd IT Team George" and have no reasonable way of finding out what the error was given the error message