johnnythesnake12 / pe

0 stars 0 forks source link

Delete 20 and Delete 20000000000000000000000000000 should return the same error message #7

Open johnnythesnake12 opened 10 months ago

johnnythesnake12 commented 10 months ago

Delete 20 returns "The person index provided is invalid"

Delete 20000000000000000000000000000 returns "Invalid command format! delete: Deletes the employee identified by the index number used in the displayed employee list. Parameters: INDEX (must be a positive integer) Example: delete 1"

Functionally, they are the same as both are integers(in human terms, not in programming terms) as they both are trying to find the index of a person that does not exist.

nus-pe-bot commented 10 months ago

Team's Response

The second instance that you've mentioned is a result of integer overflow. This can be categorised as a problem caused by extreme user inputs. With reference to the CS2103T website,

since the problem can only happen in the case of deliberate sabotage, and furthermore it does not result in our system becoming unresponsive or incorrect, this should not be considered a bug.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]