search

johno / ember-cli-gravatar

An Ember component for gravatar image tags
MIT License
45 stars 24 forks source link

Rename `default` to `defaultImage` #20

Closed dhilipsiva closed 9 years ago

dhilipsiva commented 9 years ago

default is a Javascript Reserved keyword. While this is handled smartly by most browsers, others complain a Parse Error. screen shot 2015-04-14 at 13 45 15

dhilipsiva commented 9 years ago

Can we start working on version 3.0 and push it? These are critical.

johno commented 9 years ago

Sure thing :smiley_cat:

johno commented 9 years ago

Published to npm as ember-cli-gravatar@2.5.2. I published this as 2.5.2 as it isn't a breaking change. However, for 3.0 I'm wondering if we should rename this property to defaultImage to avoid the keyword altogether.

Closes #21

dhilipsiva commented 9 years ago

Yeah, that is why I actually created: https://github.com/johnotander/ember-cli-gravatar/issues/20#issuecomment-92691176 . We should rename it to defaultImage, that sounds better and unambiguous.

johno commented 9 years ago

Great, got all the related issues into the 3.0 milestone.

johno commented 9 years ago

3.0.0 is released. Thanks for all your help @dhilipsiva!

dhilipsiva commented 9 years ago

Whoa, Great! That was quick. No, thank you for the addon @johnotander :smile: