Closed andyo729 closed 7 years ago
I ended up adding a new component has-gravatar
that leaves that original component alone and just does a check with a yield.
If you think this is something that looks good, I can take the time to write tests and everything for it.
This is great! Would gladly merge this in if you could toss in some tests and documentation. Thank you!
@johnotander I moved the ajax call into a service and ran some unit tests over it. Since components aren't very good with async, I wasn't able to do integration tests. Let me know if you need anything else.
Thanks!
Radical! Thanks!
I'm attaching small Pull Request. Please have a look. I tested with our app, worked flawlessly.
Trying to think of the best way to do this. But in general my idea would be to keep the inline component as-is and then add an additional block component that yields
image
andexists
.Would look something like this: