search

johno / ember-remarkable

Ember addon for Remarkable markdown parsing helpers and components.
MIT License
26 stars 20 forks source link

Feature/remarkable plugins #23

Closed RubenSmit closed 7 years ago

RubenSmit commented 8 years ago

I saw the discussion in this issue https://github.com/johnotander/ember-remarkable/issues/7 and decided to give it a go and fix it myself. Never done this kind of thing before, so I would like to see your reactions. This fixes all the problems in the issue mentioned before.

johno commented 8 years ago

Rad, looking good! Thanks for contributing! I've added a couple comments to your PR so far.

It looks like for some reason node v0.12 (in Travis CS) isn't happy with the way the configuration is being grabbed. Though, I'm not sure why? I will have some time this weekend to look into it if you don't get a chance before then.

Before I can merge we will need to add a test and docs, but I absolutely love where this is headed. 👯 🍻 😍

RubenSmit commented 8 years ago

Thanks for the comments! I will look at them later this week.

johno commented 7 years ago

Thank you so much for your work on this, we've gone ahead and added this functionality with a different PR so I will close this now.