search

johno / ember-remarkable

Ember addon for Remarkable markdown parsing helpers and components.
MIT License
26 stars 20 forks source link

Improve support for nested addons #27

Closed trentmwillis closed 7 years ago

trentmwillis commented 7 years ago

Currently, this addon has some issues when being used as a nested addon (such as within an Engine). This PR improves that experience by doing two things:

  1. Simplifies exports in the app folder by re-exporting definitions from the addon folder.
  2. Ensures the proper import context is used during build, so that the imports are properly found when nested.
johno commented 7 years ago

Radical, thank you! 🙏 🙇‍♀️

johno commented 7 years ago

Published to npm as ember-remarkable@3.3.0.