johno / ember-remarkable

Ember addon for Remarkable markdown parsing helpers and components.
MIT License
26 stars 20 forks source link

Add possibility to disable highlightjs #30

Closed dennisschroer closed 7 years ago

dennisschroer commented 7 years ago

Introduction

I would be great if there were a possibility to remove the highlight.js support.

Motivation

Currently, highlightjs is always added to the dependencies, and thus to vendor.js. However, the highlightjs dependency greatly increases the size of this file. In our app, the vendor.js file is nearly 2MB, of which 500KB is caused by the highlightjs library. For our app, code highlighting is not required (we use it to markup articles)

How to

It would be great if it is possible to specify in the config whether highlight should be excluded. Something like:

config/environment.js

remarkable: {
   excludeHighlightjs: true
}

As far as I can see, this requires change in at least the following files: https://github.com/johnotander/ember-remarkable/blob/master/index.js - Do not import highlightjs when it is excluded https://github.com/johnotander/ember-remarkable/blob/master/addon/components/md-text.js - Make the highlight function depending on whether highlight is used

I will see if I can setup a PR. Any tips in the meantime?