search

johno / pixyll

A simple, beautiful Jekyll theme that's mobile first
http://pixyll.com
MIT License
2.05k stars 1.34k forks source link

Update screenshot #399

Closed thedch closed 5 years ago

thedch commented 5 years ago

Hi all --

Thought I'd take a swing at #90 -- not sure if this is what you had in mind.

Best, Daniel

Fixes #90.

ashawley commented 5 years ago

Thanks for taking this on!

I'm not sure what @johno had in mind for #90. Maybe just updating is all it was?

ashawley commented 5 years ago

Could it be renamed screenshot.png and put it in the root directory? That seems to be the convention for other Jekyll themes.

The file size is 372k. That seems pretty large. Maybe resizing it would make it smaller.

I wonder if there is a convention for this kind of thing with the Jekyll theme sites (1 2) or for Jekyll themes generally?

plttn commented 5 years ago

Just ran the screenshot through TinyPNG and came up with something that is now 62KB. homepage 1

johno commented 5 years ago

Yep, exactly what I had in mind - updating it to the latest v2 and making retina-friendly. Thanks folks 💟! And yeah, let's optimize that puppy to shrink the dl size.

thedch commented 5 years ago

compressed + renamed + moved :)

ashawley commented 5 years ago

Can you squash the commits together?

We should avoid having the larger copy of the file in the repo history.

thedch commented 5 years ago

do you want to do a squash merge?

ashawley commented 5 years ago

Merged in 2ad5051.

ashawley commented 5 years ago

Thanks for doing this! 👍