johnoneil / arib

Japan Association of Radio Industries and Businesses (ARIB) MPEG2 Transport Stream Closed Caption Decoding Tools
Apache License 2.0
57 stars 9 forks source link

Missing Dialog #8

Closed johnoneil closed 10 years ago

johnoneil commented 10 years ago

When forming .ass files from a .ts I'm noting some missing dialog. This may be because the dialog just isn't in the .ts, but it's more likely they dialog is being dropped fro some reason.

Investigation needed.

johnoneil commented 10 years ago

Certainly found cases where dialog is correctly extracted from the .ts and put into the .ass file, but the timing info is such that dialog won't appear correctly. A large example below, all of which does not appear properly on screen:

Dialogue: 0,0:02:0.58,0:02:0.58,normal,,0000,0000,0000,,{\rnormal}{\c&H00ffff&}{\c&H00ffff&}\N Dialogue: 0,0:02:0.58,0:02:0.58,normal,,0000,0000,0000,,{\rnormal}{\c&H00ffff&}{\pos(310,389)}普通に{\rmedium}{\c&H00ffff&} {\rnormal}{\c&H00ffff&}お酒飲む{\rmedium}{\c&H00ffff&}。\N Dialogue: 0,0:02:16.08,0:02:16.08,normal,,0000,0000,0000,,{\rnormal}{\c&H00ffff&}{\c&Hffffff&}\N Dialogue: 0,0:02:16.08,0:02:16.08,normal,,0000,0000,0000,,{\rnormal}{\c&Hffffff&}{\pos(350,419)}<今回は…>\N Dialogue: 0,0:02:22.10,0:02:22.10,normal,,0000,0000,0000,,{\rnormal}{\c&Hffffff&}{\c&Hffffff&}\N Dialogue: 0,0:02:22.10,0:02:22.10,normal,,0000,0000,0000,,{\rnormal}{\c&Hffffff&}{\pos(270,269)}<トップバッター\N Dialogue: 0,0:02:22.10,0:02:22.10,normal,,0000,0000,0000,,{\rnormal}{\c&Hffffff&}{\pos(330,329)}松本への出題は…>\N Dialogue: 0,0:02:29.10,0:02:29.10,normal,,0000,0000,0000,,{\rnormal}{\c&Hffffff&}{\c&Hffffff&}\N Dialogue: 0,0:02:29.10,0:02:29.10,normal,,0000,0000,0000,,{\rnormal}{\c&Hffffff&}{\pos(190,89)}<本物のビールに近い{\rmedium}{\c&Hffffff&} {\rnormal}{\c&Hffffff&}味わい\N Dialogue: 0,0:02:29.10,0:02:29.10,normal,,0000,0000,0000,,{\rnormal}{\c&Hffffff&}{\pos(250,149)}うま味{\rmedium}{\c&Hffffff&} {\rnormal}{\c&Hffffff&}コクが特徴の一品>\N Dialogue: 0,0:02:36.56,0:02:36.56,normal,,0000,0000,0000,,{\rnormal}{\c&Hffffff&}{\c&Hffff00&}\N Dialogue: 0,0:02:36.56,0:02:36.56,normal,,0000,0000,0000,,{\rnormal}{\c&Hffff00&}{\pos(270,449)}わぁ〜{\rmedium}{\c&Hffff00&} {\rnormal}{\c&Hffff00&}そうか{\rmedium}{\c&Hffff00&} {\rnormal}{\c&Hffff00&}1発目\N Dialogue: 0,0:02:36.56,0:02:36.56,normal,,0000,0000,0000,,{\rnormal}{\c&Hffff00&}{\pos(290,509)}行きます{\rmedium}{\c&Hffff00&} {\rnormal}{\c&Hffff00&}行きます{\rmedium}{\c&Hffff00&}。\N

The above issue is certainly a side effect of calculating CC timing off of "clear screen" commands in the stream. I've got to improve this in some way, or perhaps ignore cases where the delta t is zero (i.e. wait until the next clear screen, which is probably more representative of the proper timing).