search

johnpallett1986 / openintents

Automatically exported from code.google.com/p/openintents
0 stars 0 forks source link

Countdown recursive action #432

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Create a countdown, set the time to 00:00:00
2. Press menu, tap Set action
3. Choose Automation tasks -> OI Countdown
4. Tap Select dountdown and select the currently edited countdown
5. Save it and start the countdown
6. To get rid of it, either uninstall the app, or uncheck the "Start 
countdown:" action and the press dismiss.

What is the expected output? What do you see instead?
Either not let me recursively start countdowns (which I however consider a 
great feature), or check, if the time is more than 0 seconds, or (and I think, 
this is the best one) show a warning "You're starting recursively the 
countdown. If the time is 0s, you will have troubles.", or combine the two last 
possibilities and if the countdown is started recursively, not allow the user 
to set the countdown to 0.

What version of the product are you using? On what operating system?
1.1.1, Android 2.3.6, Nexus S

Original issue reported on code.google.com by matej...@gmail.com on 13 Dec 2011 at 10:43

GoogleCodeExporter commented 9 years ago

Original comment by peli0...@googlemail.com on 14 Dec 2011 at 9:28

GoogleCodeExporter commented 9 years ago 
http://www.google-melange.com/gci/task/view/google/gci2011/7116277

Original comment by peli0...@googlemail.com on 31 Dec 2011 at 7:03

GoogleCodeExporter commented 9 years ago 
GCI task unclaimed.

Original comment by peli0...@googlemail.com on 4 Jan 2012 at 9:40

GoogleCodeExporter commented 9 years ago 
What is preferred, a warning or to disable recursive action if time < 1 ?

Original comment by dkremov on 7 Jan 2012 at 7:33

GoogleCodeExporter commented 9 years ago 
I think the best option is to show a toast saying "You're starting recursively 
the countdown. If the time is 0s, you will have troubles." (as suggested by the 
user that submitted the issue) if time is 0s

Original comment by dkremov on 7 Jan 2012 at 6:02

GoogleCodeExporter commented 9 years ago 
http://www.google-melange.com/gci/task/view/google/gci2011/7116277

Original comment by peli0...@googlemail.com on 7 Jan 2012 at 9:48

GoogleCodeExporter commented 9 years ago 
Probably a dialog is better than a toast if the text is long, otherwise it is 
difficult to read.

I don't think this is a very big issue, since the original poster already gave 
a workaround:
> uncheck the "Start countdown:" action and the press dismiss.

Original comment by peli0...@googlemail.com on 7 Jan 2012 at 9:58

GoogleCodeExporter commented 9 years ago 
Well, yes, you're right, maybe I should find another issue, but will think 
about it tomorrow.

Original comment by dkremov on 7 Jan 2012 at 10:00

GoogleCodeExporter commented 9 years ago 
GCI task unclaimed.

Actually I just had another idea:
The main problem is that the "Dismiss" button does not work when the countdown 
calls itself after 0 seconds.

So in order to fix this task, there is no need to show a toast or dialog. The 
only thing that is really required is to make "Dismiss" button work: So Dismiss 
should stop the current task, but it should also stop any ongoing timer that 
has been launched in the mean-time, so that one can always dismiss a task 
easily.

This should also work if more than one countdown call each other in a loop, all 
set to 0 seconds. Dismiss any of them to stop the whole loop.

I think this would solve the issue.

Original comment by peli0...@googlemail.com on 8 Jan 2012 at 12:56