search

johnpancoast / tasker

A simple PHP job scheduler
MIT License
9 stars 2 forks source link

use Gush and PR flow so we can review #10

Closed cordoval closed 10 years ago

cordoval commented 10 years ago

just a reminder, is very hard to review code without these

johnpancoast commented 10 years ago

I'm torn on this. I think that PRs are good. But they aren't necessary in everyone's flow. Not to mention, many people build their git projects outside of github and later put them up.

PRs are useful for reading but git diffs are just the same.

Thoughts?

cordoval commented 10 years ago

if you want nobody to review or help your coding then don't use it if you want to make it very hard for others to check your advance don't use it if you want to not notify nobody on the watch list and nobody find your pushes don't use it .... many more reasons

you don't spend much time learning Gush, and it will help at work too

johnpancoast commented 10 years ago

Points taken and I agree. Closing this since future changes will be in PRs.