johnpapa / angular-tour-of-heroes

Angular - Tour of Heroes - The Next Step after Getting Started
Apache License 2.0
825 stars 1.44k forks source link

angular + webpack -> core.es5.js bundling warning #118

Closed lx93uv closed 7 years ago

lx93uv commented 7 years ago

it's talking about https://angular.io/docs/ts/latest/guide/webpack.html tutorial, here is my repo

build completes ok except several warnings (npm-start)

WARNING in ./~/@angular/core/@angular/core.es5.js
5870:15-36 Critical dependency: the request of a dependency is an expression

WARNING in ./~/@angular/core/@angular/core.es5.js
5886:15-102 Critical dependency: the request of a dependency is an expression

How to fix it?

johnpapa commented 7 years ago

closing since this was rewritten with the CLI

matrumz commented 7 years ago

@johnpapa Not everyone is using the CLI: I am one of those people who wants to build everything from the ground up as a learning experience. If this question could be answered, I'd be very appreciative.

WARNING in ./node_modules/@angular/core/@angular/core.es5.js 5644:15-36 Critical dependency: the request of a dependency is an expression

WARNING in ./node_modules/@angular/core/@angular/core.es5.js 5660:15-102 Critical dependency: the request of a dependency is an expression

joshuawilson commented 7 years ago

Can you point to how it was rewritten in the CLI, so those of us that don't use can make the same change?

johnpapa commented 7 years ago

sure, check the commit history.

https://github.com/johnpapa/angular-tour-of-heroes/pull/120/files

joshuawilson commented 7 years ago

thanks