search

johnpapa / gulp-patterns

Playground for Gulp Recipes
500 stars 146 forks source link

Iss92 #93

Closed EnergeticPixels closed 9 years ago

EnergeticPixels commented 9 years ago

John, while attempting to survey if your 'patterns' would work for me at the office for this FYs contracts, I discovered that gulp-ng-annotate version 0.3.2 was causing build failures. Version 4 of that module, fails silently but still fails. Version 5 of gulp-ng-annotate builds perfectly within your project. Please review and accept. gulp-patterns_ngannotateversion42__errorbombsout gulp-patterns_ngannotateversion43__errorsilentlyfails gulp-patterns_ngannotateversion40__buildsperfect

Respectfully, Anthony Jackman Serco Inc Software Engineer II US Navy Cryptologist

EnergeticPixels commented 9 years ago

Cool. This was my first official pull request. I just finished Code School's Mastering Github course. Took me twice going through the course to get the hang of how the flow is supposed to go. And then I happened to run into your issue 92. It was an easy thing to attempt to get right. Thanks for the merge. tony