search

johnpapa / lite-server

Lightweight node server
MIT License
2.31k stars 267 forks source link

Re-enable `injectChanges` #81

Open NZSmartie opened 8 years ago

NZSmartie commented 8 years ago

Angular2 appears to work with injectChanges: true set in bs-config.js

I'm not sure when it started to work, but CSS changes successfully inject into my angular2 app through browser sync. Note that my app is not in production mode (but that should have little impact for lite-server)

I'm only suggesting that injectChanges be reverted to it's default value since it's a lot easier to make tweeks without full page refreshes. Though, I would like to know if there test cases that i could try to see if any limitations still exist

Environment

johnpapa commented 8 years ago

I don't recall nor can I find this change. @cgmartin may have more thoughts, but I like injectChanges true too.

riddla commented 8 years ago

The new default seems to be introduced by https://github.com/johnpapa/lite-server/commit/a9f0e6b6e48e8adb844a108d3f268df0dbca0026#diff-737c7d3ff36d06af220e1692dab2ee86R8.