johnpapa / ng-demos

variety of angular demos
MIT License
1.7k stars 961 forks source link

Modular - exception-handler-provider error during minification #81

Open ManojShenoy25 opened 8 years ago

ManojShenoy25 commented 8 years ago

Dependencies for the exception handler provider are not minification safe and throw an error when I use the default aspnet bundling & minification.

Refer Line 48 in file below https://github.com/johnpapa/ng-demos/blob/master/modular/src/client/app/blocks/exception/exception-handler.provider.js

$delegate, exceptionHandler, logger dependencies for "extendExceptionHandler" function should be injected using $inject service .

ingcrengifo commented 8 years ago

you've corrected? I would like to update my code.

ManojShenoy25 commented 8 years ago

What I have done is inject the dependencies using the $inject service just before the extendExceptionHandler function. Once this was done I was able to bundle and minify without trouble.

extendExceptionHandler.$inject = ['$delegate', '$exceptionHandler','logger'];