johnpapa / vscode-angular-snippets

Angular Snippets for VS Code
MIT License
575 stars 163 forks source link

Add more form snippets #104

Closed stefnotch closed 4 years ago

stefnotch commented 4 years ago

Purpose

What

How to Test

What to Check

Verify that the following are valid

johnpapa commented 4 years ago

this is in the incorrect file and should be in the html.json file, since it applies to html.

also, is this adding additional value in your opinion over the angular langauge service snippets?

stefnotch commented 4 years ago

@johnpapa I'm slightly confused here, since my snippet is in the html.json file. Is it possible that you intended to respond to a different PR?

johnpapa commented 4 years ago

yes, please forgive me.

I checked both a-form and a-form-submit and neither is working for me. here is what I see ...

2019-12-18_11-42-47 (1)

stefnotch commented 4 years ago

I checked it out locally and it works for me. As you can see, a-form and a-form-submit do show up.

image

johnpapa commented 4 years ago

Can you try it in a file with an html extension? I wonder if there is something to that.

stefnotch commented 4 years ago

Yes of course. I cloned my repository again, to make sure that there isn't some local change. Then I npm installed everything and started it. It seems to work as expected on my end. image

johnpapa commented 4 years ago

all set now