peacock in devcontainers doesn't revert to peacock.Color when peacock.remoteColor isn't specified

[jamiekt]

Versions (please complete the following information):

• OS: mac
• VS Code version: 1.77.3 (Universal)
• Peacock Version: v4.2.2

Describe the bug Documentation states that peacock.color will be used in devcontainers if peacock.remoteColor isn't specified:

When a workspace is opened in a remote context, if a peacock.remoteColor is set, it will be applied. Otherwise, the regular peacock.color is applied.

https://papapeacockstorage.z13.web.core.windows.net/guide/#remote-development-integration

The behaviour I'm seeing though is different. If I only specify peacock.Color then no color is displayed when I open the repo in the devcontainer. if I specify peacock.remoteColor then it works as expected.

To Reproduce Steps to reproduce the behavior:

issue

cd /tmp \
  && mkdir -p peacocktest/.vscode \
  && echo '{"peacock.color": "#6217a4"}' >> peacocktest/.vscode/settings.json \
  && code peacocktest

VSCode should open up and peacock will color it a lovely shade of purple.

Now open up the command palette (CMD+Shift+P), choose "Dev Containers: Add Dev Container Configuration Files..."

Choose any image (Alpine is fine)

We're now running inside the devcontainer but the peacock color has not been activated

Edit settings.json to the following:

{
    "peacock.color": "#6217a4",
    "peacock.remoteColor": "#6217a4"
}

Upon save the peacock color will be activated and workbench.colorCustomizations gets added to settings.json

Expected behavior If the docs are to be believed then I shouldn't have to add peacock.remoteColor

[johnpapa]

Thank you @jamiekt for creating this issue!

[xgdgsc]

You may need https://github.com/johnpapa/vscode-peacock/pull/486

[jamiekt]

You may need #486

I may need what? Sorry, I don't understand your meaning.

[xgdgsc]

It' s more of a reminder for the project owner to review my PR so this kind of issue might be related.