johnpapa / vscode-peacock

Subtly change the color of your Visual Studio Code workspace. Ideal when you have multiple VS Code instances, use VS Live Share, or use VS Code's Remote features, and you want to quickly identify your editor.
MIT License
1.04k stars 118 forks source link

Works most of the time with WSL2 but containers PRESSING F1 and "peacock" gives only peacock documentation? #532

Open KonanTheLibrarian opened 1 year ago

KonanTheLibrarian commented 1 year ago

Versions:

Describe the bug Peacock with Ctrl+Shift+P and "peacock" shows only documentation. Annoying can't change colour.

Solution at a Guess This guy willpower232 . Says that you have to press the Folder icon and then it will transfer peacock metadata to a file. My take on this is without the user choosing project folder, the metadata can't stick so colours can't be chosen yet. (But Colour should reside in memory - and wait for folders to exist). So the fix will be easy to implement using a temporary location that transfers settings once the user as finally "chosen the base folder for VSCODE in a new VSCODE project instance". Obviously ask the user to chose a folder when they are choosing a colour!!!!

To Reproduce Steps to reproduce the behavior:

  1. Launch a container with Linux in it eg Debian:Latest
  2. In WSL VS CODE press Docker whale icon.
  3. Select your running container and launch it with seperate new, and it's own VSCODE instance.
  4. Press F1 and type peacock
  5. See annoying Peackock Documentation only!
  6. Press Extensions icon and find Peacock already installed.
  7. Not tried uninstalling peacock and reinstalling it (in the container).

Expected behavior Normally F1 gives peacock and the colour favourites.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Problem is long running.

johnpapa commented 1 year ago

Thank you @KonanTheLibrarian for creating this issue!

willpower232 commented 1 year ago

Is this the issue where you have to open a folder of code first before you can change any peacock settings because it writes the colours to a local file?

KonanTheLibrarian commented 1 year ago

You're Welcome! Peacock is one of the most brilliant plugins for users who run both VSCODE and Windows in dark mode - can't see the edges of windows and with 10 VSCODE instances can't tell which one is which. Peacock solves it with nice colours and you don't have to be gxy to use it ;-) My bet is this developer will be able to fix this in 1 hour as the full features are failing to shift across and stick to all instances of VS CODE ... eg Docker VSCODE separate instances.

KonanTheLibrarian commented 1 year ago

Work around from this guy willpower232 . Says that you have to press the Folder icon and then it will transfer peacock metadata to a file. Without the user choosing project folder, the metadata can't stick so colours can't be chosen yet. (But Colour should reside in memory - and wait for folders to exist). If you chose a base folder for the new project then F1 and typing "peacock" works. So the fix will be easy to implement using a temporary shared location that transfers settings once the user as finally "chosen the base folder for VSCODE in a new VSCODE project instance".