search

johnpapa / vscode-peacock

Subtly change the color of your Visual Studio Code workspace. Ideal when you have multiple VS Code instances, use VS Live Share, or use VS Code's Remote features, and you want to quickly identify your editor.
MIT License
1.03k stars 115 forks source link

Configuration settings not respected when applying, lightening or darkening color #535

Closed csandfeld closed 10 months ago

csandfeld commented 10 months ago

Versions (please complete the following information):

Describe the bug Configuration settings not respected when applying, lightening or darkening color. I configured peacock with these settings:

Afterwards color is still applied to those elements when running any of these commands:

To Reproduce Steps to reproduce the behavior:

  1. Set Peacock configuration in user settings
    • "peacock.affectActivityBar": false
    • "peacock.affectSashHover": false
    • "peacock.keepBadgeColor": true
  2. Run "Peacock: Change to a Favorite Color" to apply a color
  3. Notice that colors for the elements are changed even though they are configured not to
  4. Make the configuration take effect again by toggling each of the settings
  5. Run "Peacock: Lighten" or "Peacock: Darken"
  6. Notice that once again the elements are colorized even though they are configured not to.

Expected behavior

When configuring Peacock to not affect elements I expect those elements to not be affected when applying, lightening or darkening colors.

johnpapa commented 10 months ago

Thank you @csandfeld for creating this issue!

csandfeld commented 10 months ago

Set out to make a video of the issue, but was unable to reproduce it when starting out from scratch. Probably something screwy on my system after all.

Sorry for the inconvenience.