johnpapa / vscode-peacock

Subtly change the color of your Visual Studio Code workspace. Ideal when you have multiple VS Code instances, use VS Live Share, or use VS Code's Remote features, and you want to quickly identify your editor.
MIT License
1.03k stars 115 forks source link

Peacock stopped working - can't change colors at all #541

Open edwardtanguay opened 9 months ago

edwardtanguay commented 9 months ago

Versions (please complete the following information):

Describe the bug F1, change color does nothing, it says "activating extensions" and then stops

To Reproduce Steps to reproduce the behavior:

  1. F1
  2. change color
  3. won't work
johnpapa commented 9 months ago

Thank you @edwardtanguay for creating this issue!

gotofritz commented 8 months ago

Same here - but I am using insider.

None of the commands do anything at all, and there is no feedback in any of the terminal tabs. The extension behaves as it if wasn't there.

Version: 1.86.0-insider (Universal)
Commit: 9621add46007f7a1ab37d1fce9bcdcecca62aeb0
bharatkrishna commented 8 months ago

Seeing the same issue with

OS: MacOS Ventura 13.6.2
Version: 1.85.1 (Universal)
Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
neb commented 8 months ago

Peacock wasn't working for me and then I realized it only works with "workbench.activityBar.location": "side" (default). If you're using the new "top" option, it currently just uses sideBar theme colors.

It'd be nice if Peacock were updated to control sidebar colors (e.g. sideBar.background and sideBarSectionHeader.background) but in the meantime it does have the option to control the titleBar and statusBar colors!

So if you're using the top activity bar and don't want to switch back to the side, try adding this to your user or workspace settings:

"peacock.affectTitleBar": true,
"peacock.affectStatusBar": true,
arnoldsmyth commented 8 months ago

I have the same issue. Old workspaces that I had already colored continue in the color they were in. However new workspaces don't do anything. On old or new workspaces when I try to change the color using any method - pick a color, surprise me etc - I get a notice at the bottom "Activating Extensions" that spins for a few seconds and then it goes away but no color changes.

I am using VS Code 1.85 and am on a Mac. Solution from @neb doesn't help as I am already using side and those peacock settings were already true.

hedgeye-smarshall commented 8 months ago

I am also having this issue on the following specs:

Version: MacOS 1.85.1 (Universal) 
Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
Date: 2023-12-13T09:48:06.308Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin x64 22.6.0

although, allowing Peacock to pick colors for me w/ "Surprise Me!" feature works, and the color retains.

tonywoode commented 7 months ago

for me any attempt to set colours now ends in the affected instance eventually taking the colours of one of the other active instances (similar specs to above, MacOS)

netalex commented 6 months ago

i have all the peackock commands except form Peackock: Open the Documentation disappeared fron cmd+p menu, v4.2.2, vscode Version: 1.86.2 (system setup) Commit: 903b1e9d8990623e3d7da1df3d33db3e42d80eda Date: 2024-02-13T19:40:56.878Z Electron: 27.2.3 ElectronBuildId: 26908389 Chromium: 118.0.5993.159 Node.js: 18.17.1 V8: 11.8.172.18-electron.0 OS: Windows_NT x64 10.0.19045

eykamp commented 6 months ago

Same problem here... as reported in #516, disabling the Live Share extension (and restarting as required) fixes the problem.

ericmjl commented 5 months ago

I'm confirming that disabling LiveShare allows me to use Peacock again, but I am left a tad baffled as to why this is the case. Does anyone have a hypothesis as to why?

PuffCab commented 2 months ago

Also here to just confirm that with the disabling of LiveShare, Peacock works again. It would be great to find out what changed or what happened, since I have been using Peacock with LiveShare enabled for a very long time without issues, until a few days ago. And I don't remember any new installation or so.

tonywoode commented 2 months ago

+1 that disabling LiveShare fixed this