johnpapa / vscode-peacock

Subtly change the color of your Visual Studio Code workspace. Ideal when you have multiple VS Code instances, use VS Live Share, or use VS Code's Remote features, and you want to quickly identify your editor.
MIT License
1.04k stars 118 forks source link

refactor: break non live-share circular dependencies #548

Open talohana opened 7 months ago

talohana commented 7 months ago

I'm trying to import this extension and use it in Google, however our TS rules doesn't allow circular dependencies.

Live-share related imports are not needed, hence not resolved.

Output of npx madge --exclude='live-share' --circular --extensions ts ./:

⠋ Finding files=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.2.0

YOUR TYPESCRIPT VERSION: 5.4.5

Please only submit bug reports when using the officially supported version.

=============
Processed 53 files (3.4s) 

✔ No circular dependency found!