search

johnpatrickmorgan / FlowStacks

FlowStacks allows you to hoist SwiftUI navigation and presentation state into a Coordinator
MIT License
783 stars 56 forks source link

Xcode warning in 0.3.5 version #62

Closed ZOlbrys closed 8 months ago

ZOlbrys commented 8 months ago

[2023-10-25T18:28:09.205Z] ....akcsxqnsztlozognwdzheadarajc/SourcePackages/checkouts/FlowStacks/Sources/FlowStacks/Node.swift:22:9: error: missing return in closure expected to return 'Bool'

My team uses TCACoordinators repo (also authored by you, thank you!!) and that pulls in FlowStacks via:

.package(url: "https://github.com/johnpatrickmorgan/FlowStacks", from: "0.3.0"),

so today after 0.3.5 was released we started seeing warnings about the missing return show up.

Is this something that can be resolved? If not, we're looking into hard coding 0.3.4 since that was the last version that was working well for us, but we wanted to check!

Thank you!!

twprzybysz commented 8 months ago

@johnpatrickmorgan got crash in build

❌ **** /ios/DerivedData/SourcePackages/checkouts/FlowStacks/Sources/FlowStacks/Node.swift:22:9: missing return in closure expected to return 'Bool'

igorgcustodio commented 8 months ago

Same here.

johnpatrickmorgan commented 8 months ago

Thanks for picking up on this, and apologies for the error. Version 0.3.6 is now available and should fix the issue.