johnpbloch / wordpress-core-installer

A composer installer for WordPress core so I can stop saying core is a wordpress-plugin type package.
https://packagist.org/packages/johnpbloch/wordpress-core-installer
GNU General Public License v2.0
207 stars 49 forks source link

Use WP.org repo ZIP-s #26

Open szepeviktor opened 4 years ago

szepeviktor commented 4 years ago

@johnpbloch How about writing a Composer plugin that returns the ZIP URL-s from WP.org when wordpress/wordpress-core is required. Without a repo here on GitHub.

What do you think?

johnpbloch commented 4 years ago

Hi @szepeviktor thanks for starting the conversation! That approach was the first approach I attempted before I created johnpbloch/wordpress and johnpbloch/wordpress-core. I still think it would have been an ideal solution if I could have gotten it to work in a single command (e.g. composer require wordpress/wordpress-core) without the need for other initial setup. The blocker I ran into at the time was that composer doesn't load new plugins into memory until after repository resolution has been done, so there wasn't an easy way to give somebody a composer manifest that had that plugin and core and have them just run composer install.

As far as building such a plugin, I'm not really able to spend the time that would be required to build something like that.

That being said, something (almost) there already exists. The roots team has a WP core repo that uses the official github repo's zip files for their dist/src values: https://github.com/roots/wordpress/blob/5.3.2/composer.json for example.

Finally, I'm not sure I understand what you mean by

Without a repo here on GitHub

The plugin would have to live somewhere and be part of a package that gets installed, and most likely would need to be on packagist, which means probably hosting on GitHub. I think the only way we're going to see a truly native WordPress core package that has no need of intermediate packages and could use WP.org's zips is if core adds a composer.json manifest in the core repo itself. To which I say: I'd love to see it happen. Good luck.

szepeviktor commented 4 years ago

Thank you for your lengthy response!

Finally, I'm not sure I understand what you mean by

Without a repo here on GitHub

I've meant without hosting WordPress core on GitHub.

To which I say: I'd love to see it happen. Good luck.

I see! "Opened 7 years ago"

szepeviktor commented 4 years ago

BTW I've just released a Composer plugin that makes Envato/ThemeForest themes a package. It needs to be installed globally as you've mentioned. https://packagist.org/packages/szepeviktor/composer-envato

szepeviktor commented 4 years ago

https://github.com/roots/wordpress/releases It seems to me Roots people do not publish all WordPress core releases.