johnpbloch / wordpress-core-installer

A composer installer for WordPress core so I can stop saying core is a wordpress-plugin type package.
https://packagist.org/packages/johnpbloch/wordpress-core-installer
GNU General Public License v2.0
207 stars 48 forks source link

Make it work with Composer v2 #30

Closed szepeviktor closed 3 years ago

szepeviktor commented 3 years ago

This runs wordpress-core-installer plugin before other packages are installed.

Please see https://getcomposer.org/doc/articles/plugins.md#plugin-modifies-downloads

Fixes #29

codecov-io commented 3 years ago

Codecov Report

Merging #30 (850bcdd) into master (237faae) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #30   +/-   ##
=========================================
  Coverage     94.59%   94.59%           
  Complexity       19       19           
=========================================
  Files             2        2           
  Lines            37       37           
=========================================
  Hits             35       35           
  Misses            2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 237faae...850bcdd. Read the comment docs.

tomjn commented 3 years ago

@szepeviktor my understanding is that this is unnecessary, this installer does not make modifications to the wordpress folder

szepeviktor commented 3 years ago

https://github.com/johnpbloch/wordpress-core-installer/issues/29#issuecomment-724092670