johnpbloch / wordpress-core

Other
169 stars 40 forks source link

Alpha releases since 5.1 #18

Closed alpipego closed 5 years ago

alpipego commented 5 years ago

Since the 5.1 version there are a lot of alpha and beta builds marked as releases:

image

Is this something that can (and should) be controlled from this repository?

johnpbloch commented 5 years ago

Hi @alpipego, thanks for coming by to bring that up. That's definitely neither intended, nor desirable. I'm a little too busy right now to take care of this, but it looks like the code in https://github.com/johnpbloch/build-wp isn't sufficiently guarded against that behavior. It's supposed to build actual pre-release tags for the various release milestones (e.g. beta1 beta2, rc1, rc2, etc.), but it's clearly not working that way. If you're so inclined, I'd happily accept a PR on that repo to address the issue and keep it from happening in the future, but that's a bit low on my list of priorities at the moment.

Again, thank you for letting me know. I appreciate the feedback.

Seldaek commented 5 years ago

@johnpbloch your package is generating a ton of packagist.org update jobs (I suppose your bot is pushing syncs very often). It'd be great if you could do the following to reduce the impact a little bit:

Our CPU resources would be very appreciative ;)

johnpbloch commented 5 years ago

@Seldaek I am ashamed I'll take some time take care of these.

Seldaek commented 5 years ago

Thanks, it's not super urgent but I wanted to raise the point because your package is by far the one doing the most updates at the moment.

johnpbloch commented 5 years ago

Closing this issue as I've removed the tags and releases from github and packagist. I'll be working on https://github.com/johnpbloch/build-wp to prevent future non-release tags in the future as well as shore up the build process in general.

Seldaek commented 5 years ago

@johnpbloch thanks! That helps already a bit, but what would be even better is if you can get rid of the "build" branches https://github.com/johnpbloch/wordpress-core/branches all these named tag-*. I suspect they don't really need to be pushed ever.