search

johnpbloch / wordpress-core

Other
169 stars 40 forks source link

Composer update; Added .gitignore #22

Closed jcchikikomori closed 5 years ago

johnpbloch commented 5 years ago

Thanks for taking the time to submit this pull request! The lockfile isn't really something I think should be a default part of this repository. This repository has no dependencies and shouldn't ever really be deployed as-is, so there's no reason to ship a lockfile with it.

Regarding the .gitignore file, I'm not entirely convinced. The primary way this repo is used is as a dependency, which means it is going to be ignored entirely anyway. I'm partial to the idea of adding an ignore file as part of a post-create-project-cmd script, though. A .gitignore file makes a lot of sense when using this package in that way.

jcchikikomori commented 5 years ago

Thanks for your response. Since my forked version was only for creating projects by branching out this repo and create and modify on the new one, it makes sense