johnpbloch / wordpress-core

Other
169 stars 40 forks source link

Too low PHP min version in 6.6 #35

Closed szepeviktor closed 3 months ago

szepeviktor commented 3 months ago

https://github.com/johnpbloch/wordpress-core/blob/3c8068623544eebbe45786dc20221c3cfed7a683/composer.json#L26

@johnpbloch Now 6.6 branch differs from WordPress core.

johnpbloch commented 3 months ago

Thanks for letting me know. I'll update the build script later today.

szepeviktor commented 3 months ago

Glad to contribute.

johnpbloch commented 3 months ago

It appears the upstream repository prematurely created their 6.6 branch and then deleted it. Whenever they recreate the 6.6 branch, this will resolve itself.

johnpbloch commented 3 months ago

I went ahead and copied a snapshot of master into the 6.6 branch in this repo and updated the PHP version. It's essentially the same thing as master anyway, but this way anybody who mistakenly tries to install 6.6 before its release will at least get some code, even if it is out of date for a while.

szepeviktor commented 3 months ago

Thank you.