johnperry / CTP

Clinical Trial Processor
http://mircwiki.rsna.org/index.php?title=CTP_Articles
65 stars 55 forks source link

HTTP Basic authorization for XNAT interop #1

Closed karchie closed 13 years ago

karchie commented 13 years ago

Hi, John,

We've been working to get CTP to play nicely with XNAT, our open-source imaging informatics platform (http://xnat.org), so that we can move DICOM data from a scanner across a network into an XNAT via HTTP. This very nearly worked out of the box, but org.rsna.ctp.stdstages.HttpExportService uses a custom authorization scheme (the RSNA: header) and XNAT wants HTTP Basic. I've modified HttpExportService to have an extra "authorization" attribute in the config.xml that, if set to "HTTP-Basic", uses that authorization scheme instead. Otherwise, it uses the default RSNA authorization.

Would it be possible for you to pull this? We have users at other sites who've been wanting to move files from the scanners to their XNAT across internal network boundaries, and it would be much easier to just point them to CTP than to distribute a fork.

Thanks!

johnperry commented 13 years ago

Kevin:

I have wanted to switch to Basic authentication in the HttpExportService for a long time, so instead of pulling in your code, I just changed to Basic auth for everything sent via the HttpExportService. (The org.rsna.server.Authenticator class still supports RSNA authentication, so the new CTP is backward compatible.)

I pushed the change to GitHub, and the new CTP installer is on the RSNA site at http://mirc.rsna.org/CTP/CTP-installer.jar.

The new version has many other changes, but all are backward compatible and none affect what you are doing.

JP

johnperry commented 13 years ago

Kevin:

I have wanted to switch to Basic authentication in the HttpExportService for a long time, so instead of pulling in your code, I just changed to Basic auth for everything sent via the HttpExportService. (The org.rsna.server.Authenticator class still supports RSNA authentication, so the new CTP is backward compatible.)

I pushed the change to GitHub, and the new CTP installer is on the RSNA site at http://mirc.rsna.org/CTP/CTP-installer.jar.

The new version has many other changes, but all are backward compatible and none should affect what you are doing.

JP